Add model_options to settings.json
#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch extends the configuration capabilities of the fm_agent. Until now, loading the model parameters from the configuration file was sufficient, but not all params can be set this way. The `--quantum=N` is one example. We need to decrease this value so the timing of the model better matches real hardware. Signed-off-by: Filip Jagodzinski <filip.jagodzinski@arm.com>
Member
Author
|
@jamesbeyond, @MarceloSalazar, please review. |
jamesbeyond
approved these changes
Oct 14, 2021
Contributor
jamesbeyond
left a comment
jamesbeyond
left a comment
There was a problem hiding this comment.
I like this improvement!
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the configuration capabilities of the fm_agent.
Until now, loading the model parameters from the configuration file was
sufficient, but not all params can be set this way. The
--quantum=Nisone example. We need to decrease this value so the timing of the model
better matches real hardware.
Signed-off-by: Filip Jagodzinski filip.jagodzinski@arm.com